Enable bootstrap.sh to determine OS and version on its own #162
Conversation
JeffMill
left a comment
JeffMill
left a comment
There was a problem hiding this comment.
looks good overall, just some suggestions added.
Is there a task on ADU to fix up the way we call DO?
| installQemu | ||
| } | ||
|
|
||
| function isSupportedLinux() |
There was a problem hiding this comment.
all of this isSupported*, determine* stuff should be in a separate script.
You can then include those methods (I think!) using "source platform-helpers.sh" in this script. #WontFix
There was a problem hiding this comment.
Good point. I'll split it out when there is another script that needs the same functionality.
build/scripts/bootstrap.sh
Outdated
|
|
||
| echo "OS = $OS" | ||
| echo "VER = $VER" | ||
| if [ "$is_amd64" = true ]; then echo "Arch = amd64" |
There was a problem hiding this comment.
determine_os_and_arch should also return $ARCH.
(in otherwords, this code should be in determine_os_and_arch and set $ARCH) #Resolved
build/scripts/bootstrap.sh
Outdated
| echo "[INFO] Installing build dependencies" | ||
|
|
||
| if [[ "$PLATFORM" == "osx" ]]; | ||
| if [ "$is_macos" = true ]; |
There was a problem hiding this comment.
rather than a bunch of "is" bools, these are mutually exclusive -- helper should set an $OSFLAVOR, e.g. "linux" e.g. if $OSTYPE == linux*
#Resolved
build/scripts/bootstrap.sh
Outdated
| function isSupportedLinux() | ||
| { | ||
| if [[ "$PLATFORM" == "debian10" || "$PLATFORM" == "ubuntu1804" || "$PLATFORM" == "ubuntu2004" ]]; | ||
| if [[ ("$OS" == "ubuntu" && ($VER == "18.04" || $VER == "20.04")) |
There was a problem hiding this comment.
is 18.xx or 20xx not supported? Why specifically 18.04 and 20.04 ? #Resolved
There was a problem hiding this comment.
There was no requirement for other versions and we have not tested this on those other versions.
| echo "Failed to get cpu architecture." | ||
| return 1 | ||
| else | ||
| if [[ $arch == aarch64* || $arch == armv8* ]]; then |
There was a problem hiding this comment.
see my other comment -- these are mutually exclusive. e.g. $ARCH_FLAVOR="arm32" would be better IMHO #Resolved
There was a problem hiding this comment.
Yes, good call.
| source: . | ||
| override-build: | | ||
| ./build/scripts/bootstrap.sh --platform ubuntu2004 --install build | ||
| ./build/scripts/bootstrap.sh --install build |
|
looks good overall, just some suggestions added. Is there a task on ADU to fix up the way we call DO? In reply to: 1335530563 |
No description provided.