Skip to content

Add support for setting client certificate#164

Merged
JeffreySaathoff merged 2 commits intodevelopfrom
user/jeffreys/clientCert
Mar 20, 2023
Merged

Add support for setting client certificate#164
JeffreySaathoff merged 2 commits intodevelopfrom
user/jeffreys/clientCert

Conversation

@JeffreySaathoff
Copy link
Contributor

No description provided.

@JeffreySaathoff JeffreySaathoff requested a review from a team as a code owner March 20, 2023 19:20
@shishirb-MSFT
Copy link
Collaborator

shishirb-MSFT commented Mar 20, 2023

Worth adding a test case? Even if it is with bogus cert data and expecting set_client_cert to fail.


In reply to: 1476816451 #Resolved

@JeffreySaathoff
Copy link
Contributor Author

Yes, I think so


In reply to: 1476816451

Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JeffreySaathoff JeffreySaathoff merged commit d6f4e40 into develop Mar 20, 2023
@JeffreySaathoff JeffreySaathoff deleted the user/jeffreys/clientCert branch March 20, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants