Skip to content

Conversation

@andretoyama-msft
Copy link
Contributor

  • Add support for ubuntu 22.04 on yml files
  • Add Ubuntu 22.04 Dockerfiles for building arm64 and amd64 images
  • Add support for building ubuntu 22.04 on bootstrap.sh file

@andretoyama-msft andretoyama-msft requested a review from a team as a code owner June 5, 2023 20:10
@shishirb-MSFT
Copy link
Collaborator

shishirb-MSFT commented Jun 12, 2023

    pip install cpplint

On a fresh 22.04 wsl2 instance, this script fails with "pip: command not found".

Looks like we need to change the pip install line to this for 22.04:
sudo apt install python3-pip


In reply to: 1587897157


Refers to: build/scripts/bootstrap.sh:120 in d7902ca. [](commit_id = d7902ca, deletion_comment = False)

@shishirb-MSFT
Copy link
Collaborator

    pip install cpplint

Did you verify python3-pip is available and works on the other OSes we build on? If yes, update the existing install cmd on line 118 instead of adding a new one.


In reply to: 1587897157


Refers to: build/scripts/bootstrap.sh:120 in d7902ca. [](commit_id = d7902ca, deletion_comment = False)

Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andretoyama-msft andretoyama-msft merged commit d0e7d7f into develop Jun 15, 2023
@andretoyama-msft andretoyama-msft deleted the user/andretoyama-msft/support-ubuntu2204 branch June 15, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants