Add notice in build instructions for modifying builder name #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimson-msft
commented
Feb 20, 2021
cmknox
reviewed
Feb 20, 2021
|
|
||
| ### Building DO client components | ||
| **NOTICE:** | ||
| **If you are modifying this project and distributing your own custom build, please modify the builder_version cmake variable located in https://github.com/microsoft/do-client/blob/main/CMakeLists.txt** |
There was a problem hiding this comment.
builder_version [](start = 94, length = 15)
would it be worth putting back ticks "`" around this to highlight it in markdown?
Contributor
Author
There was a problem hiding this comment.
The same ticks around the cmdets?
i.e.
**NOTICE:**
**If you are modifying this project and distributing your own custom build, please modify the builder_version cmake variable located in https://github.com/microsoft/do-client/blob/main/CMakeLists.txt**
'''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add disclaimer for modifying builder name in README