Pre-cpprest-removal: Extract http parser into common code #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consume it in SDK.
shishirb-MSFT
commented
Aug 25, 2021
| std::string firstLine{_incomingDataBuf.begin(), itCR}; | ||
| // std::cout << "Request/Status line: " << firstLine << std::endl; | ||
|
|
||
| static const std::regex rxRequestLine{"([a-zA-Z]+) ([a-zA-Z0-9\\-_\\.!~\\*'\\(\\)%:@&=\\+$,/?]+) [hHtTpP/1\\.]+"}; |
Collaborator
Author
shishirb-MSFT
changed the title
jimson-msft
reviewed
Aug 26, 2021
| unsigned int StatusCode() const { return _parsedData->statusCode; } | ||
| std::stringstream& Body() { return _parsedData->body; } | ||
| const std::shared_ptr<HttpPacket>& ParsedData() const { return _parsedData; } | ||
|
|
Contributor
There was a problem hiding this comment.
Consider adding some unit tests for the parser #Closed
Collaborator
Author
There was a problem hiding this comment.
Yes, will do it after code complete. For now, the sdk/agent interaction in all the downloads is sufficient.
jimson-msft
reviewed
Aug 26, 2021
| while (_ParseNextField()) | ||
| { | ||
| } | ||
| break; |
Contributor
There was a problem hiding this comment.
empty because we're not interested in anything here for the rest interface? #Closed
Contributor
There was a problem hiding this comment.
Fields here refers to the http headers correct?
Contributor
There was a problem hiding this comment.
Ah nvm, see the comment in line 128
Collaborator
Author
There was a problem hiding this comment.
Yep, the http headers. We aren't interested in anything other than Content-Length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.