Pre-cpprest-removal: Remove dependency in REST API parsing #64
Conversation
| { | ||
|
|
||
| /* | ||
| Code borrowed from cpprestsdk project: https://github.com/microsoft/cpprestsdk/ |
There was a problem hiding this comment.
@jimson-msft I've copied the code as is for the most part. Only differences are in the types (no support for wide strings) and namespaces. #Closed
* Expected due to cpprest borrowed code. * Final set of borrowed code TBD.
shishirb-MSFT
force-pushed
the
user/shishirb/ni-remove-cpprest-parser
branch
from
c82692d to
b56753e
Compare
| /* | ||
| Code borrowed from cpprestsdk project: https://github.com/microsoft/cpprestsdk/ | ||
| libcurl includes APIs to work with URLs starting from v7.62.0. | ||
| Ubuntu 18.04 ships with libcurl v7.58.0 only so we cannot use the URL API. |
There was a problem hiding this comment.
That's unfortunate :-(
Unrelated to this pr but I recently read somewhere that the fragmentation of the linux world - specifically with library and version support is what made windows so dominant for game developers - unified apis for graphics/visuals/audio on a single system with great backcompat. Very few people wanted to develop libraries to support linux distros, esp with PC market share being relatively low
We've been feeling the pain of it as well with dependency management and platform support for all these diff distros. #Closed
There was a problem hiding this comment.
Ah, I see. Yeah it is really unfortunate.
* Borrow URL parsing and building code from cpprest. * SDK: Update expected binary size by 8%. * SDK: Remove do_url_encode.h.
* Borrow URL parsing and building code from cpprest. * SDK: Update expected binary size by 8%. * SDK: Remove do_url_encode.h.
* Borrow URL parsing and building code from cpprest. * SDK: Update expected binary size by 8%. * SDK: Remove do_url_encode.h.
No description provided.