Remove cpprest dependency in REST listener #65
Conversation
Track num connections. Send agent version.
shishirb-MSFT
force-pushed
the
user/shishirb/ni-server-impl-rebase
branch
from
009e96c to
c6ec8af
Compare
| RETURN_HTTP_STATUSCODE_STR(BadRequest); | ||
| RETURN_HTTP_STATUSCODE_STR(NotFound); | ||
| RETURN_HTTP_STATUSCODE_STR(InternalError); | ||
| RETURN_HTTP_STATUSCODE_STR(ServiceUnavailable); |
There was a problem hiding this comment.
If it's not one of these 5, then the http status code string is set to "StatusDescription" in HttplistenerConnection::Reply(), is this intended? #Closed
There was a problem hiding this comment.
Yes, we currently don't use anything else. The description actually doesn't matter in the protocol since it is purely for humans to read.
| ss << "Content-Length: " << body.size() << "\r\n"; | ||
| } | ||
| ss << "Server: Delivery-Optimization-Agent/" << microsoft::deliveryoptimization::util::details::SimpleVersion() << "\r\n"; | ||
| ss << "\r\n"; |
There was a problem hiding this comment.
This crlf is used for the empty header correct? #Closed
There was a problem hiding this comment.
Yes, it signifies the end of the header section.
| if (ec) | ||
| { | ||
| DoLogError("Async accept failed, error = %d", ec.value()); | ||
| // TODO(shishirb) terminate process by throwing exception? |
There was a problem hiding this comment.
Would it make sense to try again up until n failures? #Closed
There was a problem hiding this comment.
Maybe. The only time I've seen a failure here is during shutdown notifying us that socket is closed (expected). So I'll leave it as is until we see other retry-able errors.
* Remove cpprest from listener * Listener conns keep alive. Track num connections. * Send agent version in REST response. * SDK: Fix rest_interface_tests
* Remove cpprest from listener * Listener conns keep alive. Track num connections. * Send agent version in REST response. * SDK: Fix rest_interface_tests
* Remove cpprest from listener * Listener conns keep alive. Track num connections. * Send agent version in REST response. * SDK: Fix rest_interface_tests
* Remove cpprest from listener * Listener conns keep alive. Track num connections. * Send agent version in REST response. * SDK: Fix rest_interface_tests
No description provided.