Skip to content

Conversation

@jimson-msft
Copy link
Contributor

  • Following Microsoft CELA guidance for copyright notices across all source files.
  • Files borrowed from cpprest retain cpprest license (it is up to modifier if we want to add our own contribution, but we must retain the original source files license - so the cpprest header notices are taken directly from the projects github repo)

@jimson-msft jimson-msft requested a review from a team as a code owner September 27, 2021 03:15
@@ -1,5 +1,8 @@
#!/bin/bash
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and bootstrap.sh are duplicated in build/scripts. Merge issue? #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea these files must have been retained in the previous merge, but they should be deleted now.. I'll remove in this PR

@shishirb-MSFT
Copy link
Collaborator

shishirb-MSFT commented Sep 27, 2021

Thanks for adding the cpprest header. Also, just curious - did you use any tool to automatically add the header to all files?


In reply to: 928009833


In reply to: 928009833 #Resolved

@cmknox
Copy link

cmknox commented Sep 27, 2021

Thanks @jimson-msft for adding the header to these files!


In reply to: 928031686


In reply to: 928031686


In reply to: 928031686


In reply to: 928031686

Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jimson-msft jimson-msft merged commit 75ff20b into main Sep 27, 2021
@jimson-msft jimson-msft deleted the user/jimson/add_copy_notices branch September 27, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants