Templatize Github release jobs per platform & Tar the .deb output #89
Conversation
jimson-msft
commented
Oct 4, 2021
jimson-msft
commented
- Tested this on a dry-run and release now contains 4 tar files respective to each platform
- It's a little messy the way this pipeline does the .tar file creation so that can be cleaned up in the future
|
@shishirb-MSFT If this change looks good we can also CP it into main and re-release 0.8.0 with it. I think the current release is a little ambiguous on which .deb file to use per platform |
| jobs: | ||
| - job: ${{parameters.targetOsArch}} | ||
| steps: | ||
| - checkout: self |
There was a problem hiding this comment.
That's what I thought too - but after templatization having nested templates was causing issues - the 2nd stage in the github-release.yml wasn't performing checkout unless explicitly specified. It's unclear if it's a bug or a feature, though I did see some people posting about similar issues online, but they look a bit dated:
| steps: | ||
| - checkout: self | ||
| path: 's' # Copy to sources directory (templates do not do this automatically) | ||
| - template: ../../build/linux/du/templates/doclient-lite-docker-steps.yml |
There was a problem hiding this comment.
sure, I kept them without the line to make it more obvious that this task is related to the previous job
There was a problem hiding this comment.
Thanks. Prefer the blank line. What about lines 16, 60, 66, 73?
There was a problem hiding this comment.
Oh gotcha, misunderstood the ask - thought you meant only adding spaces between jobs and tasks. Added the additional spaces
| *.deb | ||
| TargetFolder: '/tmp/${{parameters.targetOsArch}}' | ||
| CleanTargetFolder: true | ||
| displayName: 'Copy all agent .deb file' |
| - task: PublishBuildArtifacts@1 | ||
| inputs: | ||
| PathtoPublish: '$(Build.ArtifactStagingDirectory)' | ||
| ArtifactName: '${{parameters.targetOsArch}}' |
There was a problem hiding this comment.
sounds good to me
There was a problem hiding this comment.
Well, it is a required arg, so I'm going to modify publishing all .tar files to a folder called release-artifacts since we are no longer publishing the .deb files directly
There was a problem hiding this comment.
Ok we'll see if it complains due to multiple jobs writing to the same artifact name.
Co-authored-by: Jimmy Song <55897143+jimson-msft@users.noreply.github.com> Cherry-picked from #89
