Add request types to allow for mediator pattern invocation of tasks#121
Open
jviau wants to merge 13 commits intomicrosoft:mainfrom
Open
Add request types to allow for mediator pattern invocation of tasks#121jviau wants to merge 13 commits intomicrosoft:mainfrom
jviau wants to merge 13 commits intomicrosoft:mainfrom
Conversation
jviau
commented
Feb 7, 2023
Member
|
Hi @jviau , thanks for opening this! any update on this? |
Member
Author
|
@YunchuWang this PR is quite old, would need some updates and could potentially leverage some new CSharp language features for an improved experience. Next steps would be to first have a design discussion to see if the durable team wants to take this. I highly recommend it. In my usage of durable, it is far more convenient to use a mediator-style API then the source generated strongly-typed APIs. There is opportunity to leverage source-gen to help the mediator APIs also, so can get best of both worlds. But if you are interested in this, lets sync with interested parties to go over what mediator offers and how it can be the path forward for durable APIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the mediator pattern for invoking of orchestrations and activities. This allows for users to invoke activities and orchestrations via strongly-typed request objects and also to build up complex invocation patterns through additional
TaskOrchestrationContextextension methods and more derived request types. Some examples would be:ILongRuningActivityRequest<TResult>and aRunAsyncextension method for it which will handle enqueuing a polling orchestration and polling activity.AsyncPageable<T>classes to allow for paging over activities viaIAsyncEnumerable<T>in your code.This will also replace the code-generation approach for strongly typed orchestration/activity invocations. In my opinion, I prefer this route over code-generation. It is more flexible and avoids function-name conflicts. We can still explore how we can leverage code-generation to add value to this pattern though - but it will always be an optional addition.
resolves #73
TODO:
DurableTaskClientextension method for enqueuing orchestrations.