Add initial ITaskEntity abstractions#165
Merged
jviau merged 5 commits intomicrosoft:feature/entitiesfrom Jul 27, 2023
Merged
Conversation
jviau
commented
Jul 10, 2023
sebastianburckhardt
requested changes
Jul 21, 2023
Member
sebastianburckhardt
left a comment
sebastianburckhardt
left a comment
There was a problem hiding this comment.
looks good to me. I have one suggestion that seems relevant (allow empty string for entity keys) and beyond that just a few minor comments/suggestions.
| /// <param name="id">The entity to signal.</param> | ||
| /// <param name="operationName">The operation name.</param> | ||
| /// <param name="input">The operation input.</param> | ||
| /// <param name="options">The options to signal with.</param> |
Member
There was a problem hiding this comment.
would it make sense to mention here that it is possible to pass a DateTimeOffset directly (thanks to the implicit conversion)?
Member
Author
There was a problem hiding this comment.
I would prefer to leave that for discovery by looking at the SignalEntityOptions type itself. Purely because if I add it here, I should be adding it to all the other usages of it for consistency. And that seems like a lot of extra comments for little value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #163
This PR adds abstractions and supporting types for authoring durable entities:
ITaskEntityTaskEntityOperationTaskEntityContext