Add method dispatching TaskEntity base class#171
Merged
jviau merged 6 commits intomicrosoft:feature/entitiesfrom Aug 8, 2023
Merged
Add method dispatching TaskEntity base class#171jviau merged 6 commits intomicrosoft:feature/entitiesfrom
jviau merged 6 commits intomicrosoft:feature/entitiesfrom
Conversation
Member
I think we need to support this. It is very common for entity operations to perform I/O and restricting our users to do synchronous I/O is pretty terrible (in fact, synchronous I/O is "forbidden" in some contexts). |
sebastianburckhardt
approved these changes
Aug 7, 2023
Member
sebastianburckhardt
left a comment
There was a problem hiding this comment.
A few minor suggestions, looks good overall.
Member
Author
Ah okay, so we do allow for yielding of the thread in an entity. Good to know. Will add that support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #164
Adds a
TaskEntityabstract class which can be used for implementing entities where all public methods are considered operations.What is supported?
Customers can derive from
TaskEntityand add public methods to their type which will be considered operations. These public methods work as follows:input. It is defined as any parameter which does not matchTaskEntityContextorTaskEntityOperation.TaskorValueTask(until we determine this support is needed).