Separate entity state from TaskEntityContext onto its own object#179
Merged
jviau merged 1 commit intomicrosoft:feature/entitiesfrom Aug 28, 2023
Merged
Separate entity state from TaskEntityContext onto its own object#179jviau merged 1 commit intomicrosoft:feature/entitiesfrom
jviau merged 1 commit intomicrosoft:feature/entitiesfrom
Conversation
sebastianburckhardt
approved these changes
Aug 28, 2023
Member
sebastianburckhardt
left a comment
sebastianburckhardt
left a comment
There was a problem hiding this comment.
LGTM.
(I did not look at the tests but given the current priorities and timeline I think that is appropriate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates entity state from
TaskEntityContextintoTaskEntityState, which is available off ofTaskEntityOperation. The PR also removes binding ofTaskEntityOperationfromTaskEntity<TState>. The end result is that when usingTaskEntity<TState>, users have no direct access to the operation or state. This is to prevent confusing behavior when trying to use direct entity state interactions withinTaskEntity<TState>. If a user wants direct operation access, they should derive fromITaskEntity.