Fixes to entity implementation

src/Shared/Grpc/ProtoUtils.cs

@@ -7,6 +7,7 @@
 using System.Text;
 using DurableTask.Core;
 using DurableTask.Core.Command;
+using DurableTask.Core.Entities;
 using DurableTask.Core.Entities.OperationFormat;
 using DurableTask.Core.History;
 using Google.Protobuf;
@@ -631,6 +632,25 @@ internal static OrchestrationStatus ToCore(this P.OrchestrationStatus status)
         return batchResult;
     }
 
+    /// <summary>
+    /// Converts the gRPC representation of orchestrator entity parameters to the DT.Core representation.
+    /// </summary>
+    /// <param name="parameters">The DT.Core representation.</param>
+    /// <returns>The gRPC representation.</returns>
+    [return: NotNullIfNotNull("parameters")]
+    internal static TaskOrchestrationEntityParameters? ToCore(this P.OrchestratorEntityParameters? parameters)
+    {
+        if (parameters == null)
+        {
+            return null;
+        }
+
+        return new TaskOrchestrationEntityParameters()
+        {
+            EntityMessageReorderWindow = parameters.EntityMessageReorderWindow.ToTimeSpan(),
+        };
+    }
+
     /// <summary>
     /// Gets the approximate byte count for a <see cref="P.TaskFailureDetails" />.
     /// </summary>

src/Worker/Core/Shims/TaskOrchestrationContextWrapper.cs

@@ -202,11 +202,6 @@ public override async Task CreateTimer(DateTime fireAt, CancellationToken cancel
     /// <inheritdoc/>
     public override Task<T> WaitForExternalEvent<T>(string eventName, CancellationToken cancellationToken = default)
     {
-        if (typeof(T) == typeof(OperationResult))
-        {
-            throw new ArgumentException($"the type {nameof(OperationResult)} cannot be used for application-defined events", nameof(T));
-        }
-
         // Return immediately if this external event has already arrived.
         if (this.externalEventBuffer.TryTake(eventName, out string? bufferedEventPayload))
         {

src/Worker/Core/Shims/TaskOrchestrationEntityContext.cs

@@ -76,7 +76,7 @@ public override async Task<IAsyncDisposable> LockEntitiesAsync(IEnumerable<Entit
                 //    entityMessageEvent.ToString());
             }
 
-            this.wrapper.innerContext.SendEvent(entityMessageEvent.TargetInstance, entityMessageEvent.EventName, entityMessageEvent.ContentAsObject());
+            this.wrapper.innerContext.SendEvent(entityMessageEvent.TargetInstance, entityMessageEvent.EventName, entityMessageEvent);
 
             OperationResult result = await this.wrapper.WaitForExternalEvent<OperationResult>(criticalSectionId.ToString());
 
@@ -155,7 +155,7 @@ public void ExitCriticalSection(Guid? matchCriticalSectionId = null)
                         //    releaseMessage.EventContent);
                     }
 
-                    this.wrapper.innerContext.SendEvent(releaseMessage.TargetInstance, releaseMessage.EventName, releaseMessage.ContentAsObject());
+                    this.wrapper.innerContext.SendEvent(releaseMessage.TargetInstance, releaseMessage.EventName, releaseMessage);
                 }
             }
         }
@@ -212,7 +212,7 @@ Guid SendOperationMessage(string instanceId, string operationName, object? input
                 //    entityMessageEvent.ToString());
             }
 
-            this.wrapper.innerContext.SendEvent(entityMessageEvent.TargetInstance, entityMessageEvent.EventName, entityMessageEvent.ContentAsObject());
+            this.wrapper.innerContext.SendEvent(entityMessageEvent.TargetInstance, entityMessageEvent.EventName, entityMessageEvent);
 
             return guid;
         }

src/Worker/Grpc/GrpcOrchestrationRunner.cs

@@ -113,7 +113,7 @@ public static string LoadAndRun(
             ? DurableTaskShimFactory.Default
             : ActivatorUtilities.GetServiceOrCreateInstance<DurableTaskShimFactory>(services);
         TaskOrchestration shim = factory.CreateOrchestration(orchestratorName, implementation, parent);
-        TaskOrchestrationExecutor executor = new(runtimeState, shim, BehaviorOnContinueAsNew.Carryover);
+        TaskOrchestrationExecutor executor = new(runtimeState, shim, BehaviorOnContinueAsNew.Carryover, request.EntityParameters.ToCore());
         OrchestratorExecutionResult result = executor.Execute();
 
         P.OrchestratorResponse response = ProtoUtils.ConstructOrchestratorResponse(