Skip to content

Several fixes to entity implementation#202

Merged
sebastianburckhardt merged 4 commits intofeature/entitiesfrom
core-entities/more-fixes
Oct 3, 2023
Merged

Several fixes to entity implementation#202
sebastianburckhardt merged 4 commits intofeature/entitiesfrom
core-entities/more-fixes

Conversation

@sebastianburckhardt
Copy link
Member

Three fixes in this PR for issues that were discovered during testing:

  • some of the design changes for OperationResult were not fully reflected (was still using errorContext/ ErrorMessage)
  • did not have enough parameter checking for entity ids that are passed in
  • the orchestration executor was not being passed the entity backend parameters

Also, one design changes per online discussion

  • add a TaskEntityOperation parameter to the InitializeState call

@sebastianburckhardt sebastianburckhardt added durable-entities Related to the Durable Entities support milestone P1 labels Oct 2, 2023
@sebastianburckhardt sebastianburckhardt merged commit fcae915 into feature/entities Oct 3, 2023
@sebastianburckhardt sebastianburckhardt deleted the core-entities/more-fixes branch October 3, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

durable-entities Related to the Durable Entities support milestone P1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants