Merged
Conversation
# Conflicts: # samples/AzureFunctionsApp/AzureFunctionsApp.csproj
jviau
added
the
durable-entities
jviau
commented
Oct 5, 2023
| <PackageReference Include="Microsoft.Azure.Functions.Worker" Version="1.18.0" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.DurableTask" Version="1.0.2" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker" Version="1.19.0" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.DurableTask" Version="1.1.0-entities-preview.2" /> |
Member
Author
There was a problem hiding this comment.
1.1.0-entities-preview.2 does not exist yet. But preview.1 is broken, so we will be publishing preview.2 eventually.
sebastianburckhardt
approved these changes
Oct 6, 2023
Member
sebastianburckhardt
left a comment
sebastianburckhardt
left a comment
There was a problem hiding this comment.
LGTM.
Optionally, one thing that could be added is a demonstration of the DI, for example injecting an ILogger or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds entities samples along with nuget feeds and packages updated to allow the project to build.