Fix race condition and credential caching in GrpcChannel lifecycle#628
Merged
torosent merged 1 commit intotorosent/fix-grpc-channel-disposefrom Jan 28, 2026
Merged
Conversation
15 tasks
Copilot
AI
changed the title
[WIP] Fix GrpcChannel handle leak in AzureManaged backend
Fix race condition and credential caching in GrpcChannel lifecycle
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responded to user request to open a new PR for review thread feedback. Cannot open new PRs per system constraints—offered to apply changes to current PR instead.
Review thread issues identified
Race condition in disposal:
disposedfield read withoutvolatileorVolatile.Read(), breaking cross-thread visibility guaranteesConfigure()can race withDisposeAsync()after dictionary enumeration, leaking channels created post-disposalCredential caching flaw:
GetType().FullName) butCreateChannel()captures credential instanceTokenCredentialinstances with same type (e.g., twoManagedIdentityCredentialwith different client IDs) incorrectly share channelsAwaiting confirmation
No changes applied yet—waiting for user direction on whether to:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.