Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves type-hinting for orchestrator and activity registration methods by adding generic type parameters to better specify input and output types.
Changes:
- Enhanced type hints for Orchestrator and Activity type aliases with proper generic parameters
- Updated method signatures in
_RegistryandTaskHubGrpcWorkerclasses to use parameterized types - Updated CHANGELOG to document the improvements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| durabletask/task.py | Updated Orchestrator type alias to properly parameterize Generator return type and yield type |
| durabletask/worker.py | Added generic type parameters to orchestrator and activity registration methods in both _Registry and TaskHubGrpcWorker classes |
| CHANGELOG.md | Added entry for type-hinting improvements in Unreleased section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
durabletask/task.py
Outdated
|
|
||
| # Orchestrators are generators that yield tasks and receive/return any type | ||
| Orchestrator = Callable[[OrchestrationContext, TInput], Union[Generator[Task, Any, Any], TOutput]] | ||
| # Orchestrators are generators that yield tasks, recieve any type, and return TOutput |
There was a problem hiding this comment.
Spelling error: "recieve" should be "receive"
Suggested change
| # Orchestrators are generators that yield tasks, recieve any type, and return TOutput | |
| # Orchestrators are generators that yield tasks, receive any type, and return TOutput |
berndverst
approved these changes
Jan 12, 2026
This was referenced Jan 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds/improves type-hinting for various worker methods
Covers changes from #91
Short-term fix for #90
Resolves #94