Add metadata option to intercept grpc channel#16
Merged
cgillum merged 8 commits intomicrosoft:mainfrom Sep 20, 2023
Merged
Conversation
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
cgillum
requested changes
Sep 15, 2023
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
cgillum
reviewed
Sep 18, 2023
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
The approach of using an interceptor makes sense for this use-case. However, I'm wondering if we can reduce the overhead of the current implementation and make it a bit simpler. See my code comments.
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
3 tasks
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
cgillum
reviewed
Sep 19, 2023
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Last comment, again for performance.
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
passuied
pushed a commit
to passuied/durabletask-python
that referenced
this pull request
Sep 27, 2025
…ers-2 chore: add codeowners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds option to pass a metadata to be used to intercept grpc channel.
This can be used to pass API Token kind of information.