Conversation
- Known gap - VersionFailureStrategy.REJECT, no abandon strategy yet
andystaples
left a comment
There was a problem hiding this comment.
Notes to self:
- Add rejection - cleanup comments - suborch default versioning
| @@ -0,0 +1,3 @@ | |||
| class AbandonOrchestrationError(Exception): | |||
| def __init__(self, *args: object) -> None: | |||
| super().__init__(*args) | |||
There was a problem hiding this comment.
I'm not super happy with this small file or propagating information using exceptions like I'm doing. Open to better solutions
berndverst
left a comment
There was a problem hiding this comment.
The PR looks good. The one thing I am wondering about:
Am I able to actually provide two versions of my orchestration that live side by side (say 1.2.0 and 1.2.2) and route to the correct version according to either the version I requested or my policies?
I don't see any tests covering this and it's not clear to me whether / how this is possible.
Short answer... not really |
|
Per off GitHub discussion this looks good. |
Adds orchestration versioning support
Syntax:
To add a versioning strategy to the worker:
To add a default version to the client (version to use when scheduling new orchestrations):
To schedule an orchestration with a manual version:
To schedule a sub-orchestration with a manual version: