Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging visibility by adding orchestration names to log messages and promoting key activity/entity execution logs from debug to info level.
- Extracts and includes orchestration names in orchestration-related log messages
- Promotes activity and entity execution log messages from debug to info level for better visibility
- Adds a new log message at the beginning of orchestration replay
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
andystaples
commented
Nov 6, 2025
Comment on lines
+1236
to
+1239
| orchestration_name = "<unknown>" | ||
| orchestration_started_events = [e for e in old_events if e.HasField("executionStarted")] | ||
| if len(orchestration_started_events) >= 1: | ||
| orchestration_name = orchestration_started_events[0].executionStarted.name |
Contributor
Author
There was a problem hiding this comment.
This change is QoL, not sure if it is worth the time to include, given it involves another iteration over old_events.
In durabletask-dotnet, they use this logic
https://github.com/Azure/durabletask/blob/8576bc5777119c673857b87c1e85992a1111d437/src/DurableTask.Core/OrchestrationRuntimeState.cs#L148
berndverst
reviewed
Nov 11, 2025
berndverst
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #47