This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Port Envoy tests to windows#17
Open
kavyako wants to merge 6 commits intowin32_portfrom
Open
Conversation
added 6 commits
June 4, 2018 05:36
…r IPv6 addresses. Use sockaddr_storage instead. proxy_protocol_test (IpVersions/ProxyProtocolTest.Basic) fails on windows due to this issue.
…mplTest. On windows, 0.0.0.0 does not work for outbound connections. Hence default to loopback.
1. context_impl.cc:ContextImpl::ContextImpl: SSL_CTX_set_strict_cipher_list() throws exception:
Failed to initialize cipher suites {}.
tls: remove legacy SHA-2 CBC cipher suites. (Port envoy PR#3316)
They are insecure and were removed from BoringSSL codebase in
https://boringssl-review.googlesource.com/c/boringssl/+/27944
2. 20 failing tests due to:
context_config_impl: ServerContextConfigImpl::validateAndAppendKey() throws exception:
unknown file: error: C++ exception with description "Incorrect TLS session ticket key length. Length 25, expected length 80." thrown in the test body.
Reading the session ticket key file fails. Session ticket key is generated by
"openssl rand <bytelength> -out session_ticket_key_file"
It contains raw random data which is not encoded with the standard character sets.
Reading it as a text file fails, use std::ifstream in std::ios_base::openmode::binary.
…equest_info, router, tracing, thread_local etc to windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Port tests under common to windows.
CMake build files will be replaced by bazel soon.
Folders under common that are included in this port: common, access_log, api, buffer, config, ssl, event, filesystem, json, html, ratelimit, request_info, router, tracing, thread_local.
Fix issue in source/common/network: In ConnectionImpl::noDelay, getsockname fails with 10014 WSAEFAULT for IPv6 addresses. Use sockaddr_storage instead.
proxy_protocol_test (IpVersions/ProxyProtocolTest.Basic) fails on windows due to this issue.
Test fix for windows :CodecNetworkTest, ConnectionImplTest, ListenerImplTest.
On windows, 0.0.0.0 does not work for outbound connections. Hence default to loopback.
ssl fixes for win32 port:
context_impl.cc:ContextImpl::ContextImpl:
SSL_CTX_set_strict_cipher_list() throws exception:
Failed to initialize cipher suites {}.
tls: remove legacy SHA-2 CBC cipher suites. (Port envoy PR#3316)
They are insecure and were removed from BoringSSL codebase in
https://boringssl-review.googlesource.com/c/boringssl/+/27944
20 failing tests due to:
context_config_impl: ServerContextConfigImpl::validateAndAppendKey() throws exception:
unknown file: error: C++ exception with description "Incorrect TLS session ticket key length. Length 25, expected length 80." thrown in the test body.
Reading the session ticket key file fails. Session ticket key is generated by
"openssl rand -out session_ticket_key_file"
It contains raw random data which is not encoded with the standard character sets.
Reading it as a text file fails, use std::ifstream in std::ios_base::openmode::binary.
Risk Level: Low
Testing: Ran the tests on windows.
Docs Changes: TBD
Release Notes: TBD