Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Conversation

@bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Apr 24, 2019

fix(Button): focus outline

TODO

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1257 into master will decrease coverage by <.01%.
The diff coverage is 48.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   72.14%   72.13%   -0.01%     
==========================================
  Files         731      732       +1     
  Lines        5596     5617      +21     
  Branches     1636     1635       -1     
==========================================
+ Hits         4037     4052      +15     
- Misses       1554     1560       +6     
  Partials        5        5
Impacted Files Coverage Δ
...high-contrast/components/Button/buttonVariables.ts 0% <ø> (ø) ⬆️
...s/components/RadioGroup/radioGroupItemVariables.ts 0% <ø> (ø) ⬆️
...teams/components/Attachment/attachmentVariables.ts 0% <ø> (ø) ⬆️
.../themes/teams/components/Button/buttonVariables.ts 0% <ø> (ø) ⬆️
...es/teams-dark/components/Button/buttonVariables.ts 0% <ø> (ø) ⬆️
...eams/components/RadioGroup/radioGroupItemStyles.ts 18.18% <0%> (+1.51%) ⬆️
...es/teams/components/Attachment/attachmentStyles.ts 11.11% <0%> (+1.11%) ⬆️
packages/react/src/themes/base/siteVariables.ts 100% <100%> (ø) ⬆️
...ct/src/themes/teams-high-contrast/siteVariables.ts 100% <100%> (ø) ⬆️
packages/react/src/themes/teams/siteVariables.ts 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f47c35...f87fffe. Read the comment docs.

@bmdalex bmdalex force-pushed the fix/button-border-bug-2 branch 6 times, most recently from 2fa0726 to aea0c8b Compare April 25, 2019 10:59
@bmdalex bmdalex force-pushed the fix/button-border-bug-2 branch 4 times, most recently from bcded46 to bdeaae1 Compare April 25, 2019 12:35
@bmdalex bmdalex force-pushed the fix/button-border-bug-2 branch from bdeaae1 to f87fffe Compare April 25, 2019 12:54
@bmdalex
Copy link
Collaborator Author

bmdalex commented Apr 25, 2019

Closing in favor of #1269

@bmdalex bmdalex closed this Apr 25, 2019
@bmdalex bmdalex deleted the fix/button-border-bug-2 branch April 25, 2019 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants