This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(chat): focus outline #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
added
🧰 bug
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
force-pushed
the
feat/chat-focus-outline
branch
from
e931201 to
a4d81f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
=======================================
Coverage 72.31% 72.31%
=======================================
Files 762 762
Lines 5765 5765
Branches 1711 1711
=======================================
Hits 4169 4169
Misses 1590 1590
Partials 6 6
Continue to review full report at Codecov.
|
mnajdova
reviewed
May 13, 2019
packages/react/src/themes/teams-high-contrast/components/Chat/chatMessageVariables.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
May 13, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
May 13, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
bmdalex
force-pushed
the
feat/chat-focus-outline
branch
from
a4d81f8 to
4739706
Compare
mnajdova
reviewed
May 14, 2019
packages/react/src/themes/teams/components/Chat/chatMessageVariables.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
May 14, 2019
packages/react/src/themes/teams-dark/components/Chat/chatMessageVariables.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
May 14, 2019
docs/src/examples/components/Chat/Types/ChatExample.shorthand.tsx
Outdated
Show resolved
Hide resolved
bmdalex
force-pushed
the
feat/chat-focus-outline
branch
from
aaab4a0 to
f1ad731
Compare
Collaborator
|
should you also add screener tests for chatmessages in dark and hc themes? |
bmdalex
force-pushed
the
feat/chat-focus-outline
branch
from
f1ad731 to
e5d4d68
Compare
Collaborator
Author
@codepretty added tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(chat): focus outline
BREAKING CHANGES MITIGATION
Rename
Chat.Messagevariable:contentFocusOutlineColorlinkColorDescription
This PR:
attachedprop is used Chat: focus border is not fully visible whenattachedprop is used #800Chatcomponents to the latest design for borders (as outlined in feat(border): focus styles mechanism #1269)Screenshots
Before
After