Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Jan 29, 2020

Extracted #2207.

Background

Previously appendLog(), clearLog() and items[] for logging knobs where stored in one React Context and this creates useless updates for useLogKnob() as it receives notifications about items[] updates and this produces unwanted renders of component's examples.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jan 29, 2020

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.61 0.4 1.53:1 2000 1218
🔧 Button.Fluent 1.33 0.18 7.39:1 1000 1334
🔧 Checkbox.Fluent 1.34 0.29 4.62:1 1000 1339
🔧 Dialog.Fluent 0.34 0.17 2:1 5000 1723
🔧 Dropdown.Fluent 3.6 0.36 10:1 1000 3602
🔧 Icon.Fluent 0.24 0.03 8:1 5000 1183
🔧 Image.Fluent 0.1 0.08 1.25:1 5000 496
🔧 Slider.Fluent 1.91 0.28 6.82:1 1000 1905
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 258
🦄 Tooltip.Fluent 0.42 18.42 0.02:1 5000 2106

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ListMinimalPerf.default 999 716 1.4:1
AnimationMinimalPerf.default 655 536 1.22:1
TextMinimalPerf.default 279 236 1.18:1
AttachmentSlotsPerf.default 4173 3703 1.13:1
ListCommonPerf.default 1306 1153 1.13:1
ToolbarMinimalPerf.default 883 780 1.13:1
DialogMinimalPerf.default 1903 1693 1.12:1
ButtonMinimalPerf.default 1432 1288 1.11:1
ProviderMinimalPerf.default 626 567 1.1:1
TableMinimalPerf.default 589 542 1.09:1
PortalMinimalPerf.default 266 246 1.08:1
Tooltip.Fluent 2106 1946 1.08:1
TextAreaMinimalPerf.default 3098 2886 1.07:1
Dialog.Fluent 1723 1617 1.07:1
Dropdown.Fluent 3602 3411 1.06:1
DropdownMinimalPerf.default 3749 3577 1.05:1
GridMinimalPerf.default 947 899 1.05:1
HeaderMinimalPerf.default 433 414 1.05:1
ImageMinimalPerf.default 522 498 1.05:1
InputMinimalPerf.default 1082 1033 1.05:1
TreeMinimalPerf.default 972 927 1.05:1
DropdownManyItemsPerf.default 482 470 1.03:1
MenuButtonMinimalPerf.default 1630 1583 1.03:1
DividerMinimalPerf.default 898 878 1.02:1
HeaderSlotsPerf.default 1294 1278 1.01:1
CheckboxMinimalPerf.default 7142 7174 1:1
Icon.Fluent 1183 1185 1:1
Slider.Fluent 1905 1898 1:1
AlertMinimalPerf.default 641 646 0.99:1
AttachmentMinimalPerf.default 1074 1084 0.99:1
AvatarMinimalPerf.default 796 802 0.99:1
ButtonSlotsPerf.default 1766 1790 0.99:1
CarouselMinimalPerf.default 2151 2177 0.99:1
ChatDuplicateMessagesPerf.default 599 605 0.99:1
RefMinimalPerf.default 157 159 0.99:1
SegmentMinimalPerf.default 1251 1264 0.99:1
SliderMinimalPerf.default 1905 1923 0.99:1
SplitButtonMinimalPerf.default 12497 12643 0.99:1
TooltipMinimalPerf.default 2441 2463 0.99:1
ItemLayoutMinimalPerf.default 1685 1713 0.98:1
Text.Fluent 258 262 0.98:1
StatusMinimalPerf.default 839 869 0.97:1
VideoMinimalPerf.default 799 827 0.97:1
Avatar.Fluent 1218 1253 0.97:1
Button.Fluent 1334 1379 0.97:1
AccordionMinimalPerf.default 240 250 0.96:1
LayoutMinimalPerf.default 580 607 0.96:1
MenuMinimalPerf.default 2298 2384 0.96:1
RadioGroupMinimalPerf.default 371 388 0.96:1
Image.Fluent 496 514 0.96:1
ChatMinimalPerf.default 1719 1811 0.95:1
EmbedMinimalPerf.default 6561 6931 0.95:1
ChatWithPopoverPerf.default 641 680 0.94:1
IconMinimalPerf.default 1006 1069 0.94:1
LoaderMinimalPerf.default 2785 2963 0.94:1
ProviderMergeThemesPerf.default 1114 1180 0.94:1
ReactionMinimalPerf.default 2521 2677 0.94:1
PopupMinimalPerf.default 367 394 0.93:1
BoxMinimalPerf.default 267 290 0.92:1
Checkbox.Fluent 1339 1460 0.92:1
LabelMinimalPerf.default 1859 2033 0.91:1
FlexMinimalPerf.default 360 398 0.9:1
CustomToolbarPrototype.default 4241 4710 0.9:1
HierarchicalTreeMinimalPerf.default 800 899 0.89:1
FormMinimalPerf.default 769 869 0.88:1

Generated by 🚫 dangerJS

@layershifter layershifter merged commit c2b219d into master Feb 10, 2020
@layershifter layershifter deleted the fix/knobs-separate-contexts branch February 10, 2020 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🧰 fix Introduces fix for broken behavior. 🚀 ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants