This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(icon): color prop #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
docs/src/examples/components/Icon/Variations/IconExampleColor.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Dec 20, 2018
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
LGTM, left some comments 👍
bmdalex
force-pushed
the
feat/icon-color-prop
branch
2 times, most recently
from
80558d3 to
0df0229
Compare
kuzhelov
suggested changes
Dec 20, 2018
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
lets please take another look on removed extensibility point for IconVariables interface
Contributor
There was a problem hiding this comment.
this expression is very confusing - there should be a way to simplify this example. Actually, why slicing is necessary here?
Collaborator
Author
There was a problem hiding this comment.
just to make the example fit nicely, any suggestions for improving, @kuzhelov ?
kuzhelov
added
needs author feedback
9 tasks
bmdalex
force-pushed
the
feat/icon-color-prop
branch
from
0df0229 to
33d5cb0
Compare
bmdalex
added
🚀 ready for review
and removed
needs author feedback
bmdalex
force-pushed
the
feat/icon-color-prop
branch
2 times, most recently
from
7984a49 to
16d9f69
Compare
bmdalex
force-pushed
the
feat/icon-color-prop
branch
from
16d9f69 to
bb5eb00
Compare
kuzhelov
approved these changes
Dec 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(icon): color prop
Description
This PR:
colorprop toIconcomponentIconcolor examplesAPI
where
COLORis one of'primary' | 'secondary' | 'blue' | 'green' | 'grey' | 'orange' | 'pink' | 'purple' | 'teal' | 'red' | 'yellow' | string