[DataGrid] Avoid excessive calling of reinitialize method in JavaScript #2403
Merged
vnbaaij merged 1 commit intomicrosoft:devfrom Jul 18, 2024
Merged
[DataGrid] Avoid excessive calling of reinitialize method in JavaScript #2403vnbaaij merged 1 commit intomicrosoft:devfrom
vnbaaij merged 1 commit intomicrosoft:devfrom
Conversation
vnbaaij
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
I've seen that the problem behind the strange resizing effect, is due to the JS method being initialized too many times.
I've not investigated a lot why but the method
FinishCollectingColumnsinFluentDataGrid.razor.csis being executed each times a user click somewhere in the table. This will always re-execute the js methodenableColumnResizing.I've fixed the strange behavior by editing the js file in order to not re-initialize if the same grid was already initialized.
🎫 Issues
Fix #2381
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps