[General] Inject LibraryConfiguring into DesignToken#2426
Merged
vnbaaij merged 2 commits intomicrosoft:devfrom Jul 22, 2024
Merged
[General] Inject LibraryConfiguring into DesignToken#2426vnbaaij merged 2 commits intomicrosoft:devfrom
vnbaaij merged 2 commits intomicrosoft:devfrom
Conversation
- Add LibraryConfiguration to DesignTokenGenerator.
Contributor
Author
|
@microsoft-github-policy-service agree |
This was
linked to
issues
Jul 22, 2024
vnbaaij
approved these changes
Jul 22, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This issue occurs exclusively in version 4.9.2, downgrading to 4.9.1 resolves the issue.
When injecting any design token and calling
.SetValue()with any element reference, theDesignTokenclass fails to inject the registeredLibraryConfigurationcausing anObject reference not set to an instance of an objectexception to be thrown insideUrlFormatterExtensions.cs.🎫 Issues
Fix for #2425
👩💻 Reviewer Notes
Component:
Startup:
📑 Test Plan
Utilize the above code to reproduce this issue on version 4.9.2.
Rendering the Component code I outlined above, you should receive an exception on the following line without my change:
await _density.SetValueFor(Test.Element, 10);✅ Checklist
General
Component-specific
⏭ Next Steps