[DataGrid] Fix pagination when using itemprovider#2530
Merged
vnbaaij merged 4 commits intomicrosoft:devfrom Aug 20, 2024
Merged
Conversation
…ere the total amount can be different from the amount that you want to show
This comment has been minimized.
This comment has been minimized.
vnbaaij
changed the title
vnbaaij
approved these changes
Aug 20, 2024
dannyldj
pushed a commit
to dannyldj/fluentui-blazor
that referenced
this pull request
Sep 26, 2024
* use "with" instead of "assert" because of an eslint issue * Added "TotalViewItemCount" to fix pagination for the ItemsProvider where the total amount can be different from the amount that you want to show * Fixed unit test by restoring wrong used property on aria-rowcount --------- Co-authored-by: Vincent Baaij <vnbaaij@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Fix for not working pagination when using a ItemProvider because the total count is not correct
🎫 Issues
#2526
👩💻 Reviewer Notes
Reviewers should focus on the added property "TotalViewItemCount" on the internal grid context to add a difference between the total amount of items and the items in view when there is a pagination in combination with the ItemProvider.
📑 Test Plan
Manual testing has been performed.
✅ Checklist
General
Component-specific