[DatePicker] Added OnDoubleClick event and DoubleClickToDate parameter#2567
Merged
vnbaaij merged 3 commits intomicrosoft:devfrom Aug 24, 2024
Merged
[DatePicker] Added OnDoubleClick event and DoubleClickToDate parameter#2567vnbaaij merged 3 commits intomicrosoft:devfrom
vnbaaij merged 3 commits intomicrosoft:devfrom
Conversation
dvoituron
requested changes
Aug 22, 2024
…ed test for OnDoubleClick event.
vnbaaij
requested changes
Aug 23, 2024
dvoituron
approved these changes
Aug 23, 2024
Collaborator
Contributor
Author
|
Hi @dvoituron, |
Contributor
Author
|
In addition, is there a better Blazor/C# solution coming up which addresses the current |
vnbaaij
approved these changes
Aug 24, 2024
Collaborator
I would like to try to find a solution to extend this |
Collaborator
dannyldj
pushed a commit
to dannyldj/fluentui-blazor
that referenced
this pull request
Sep 26, 2024
…icrosoft#2567) * [FluentDatePicker] Added OnDoubleClick event and DoubleClickToToday parameter. * [DatePicker] DoubleClickToToday was changed to DoubleClickToDate. Added test for OnDoubleClick event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request
📖 Description
OnDoubleClickevent to DatePicker component.DoubleClickToDateparameter to DatePicker component.DoubleClickToDateoption🎫 Issues
The PR was related to
👩💻 Reviewer Notes
This is the first PR of the 2 separated PRs asked by @dvoituron which implemented the
DoubleClickToDatefeature only.📑 Test Plan
This PR kept the
FluentOverlayas-is, so it's very difficult to trigger the double-click event on the text field of the date picker, thus difficult to see this feature works. Commenting out theFluentOverlaytemporarily could help a lot during the manual tests.However, the
FluentOverlayhas no side-effect when running the test methodFluentDatePicker_DoubleClickToSetTodayInTextField, so it runs successfully. I think that's a sample of the cases that automatic tests are not exactly the same as manual tests.✅ Checklist
General
Component-specific
⏭ Next Steps
I'll move the rest "
FluentOverlayreplacement" part of the original PR #2563 to a new PR.