Skip to content

[Slider] Fix FluentSlider two-way binding issue [#2609}#2665

Merged
vnbaaij merged 4 commits intomicrosoft:devfrom
oneolddev:fix-2609
Sep 17, 2024
Merged

[Slider] Fix FluentSlider two-way binding issue [#2609}#2665
vnbaaij merged 4 commits intomicrosoft:devfrom
oneolddev:fix-2609

Conversation

@oneolddev
Copy link
Copy Markdown
Contributor

@oneolddev oneolddev commented Sep 16, 2024

Pull Request

📖 Description

Fixes two way binding issue.

🎫 Issues

  • setting value does not cause the slider thumbnail to redraw

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@oneolddev
Copy link
Copy Markdown
Contributor Author

@oneolddev please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@oneolddev
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@oneolddev oneolddev marked this pull request as ready for review September 16, 2024 22:27
@vnbaaij vnbaaij dismissed dvoituron’s stale review September 17, 2024 08:09

Already approved

@vnbaaij vnbaaij merged commit e2fc112 into microsoft:dev Sep 17, 2024
@vnbaaij vnbaaij added this to the v4.10.1 milestone Sep 17, 2024
@vnbaaij vnbaaij linked an issue Sep 17, 2024 that may be closed by this pull request
@oneolddev oneolddev deleted the fix-2609 branch September 18, 2024 14:43
@oneolddev
Copy link
Copy Markdown
Contributor Author

Adding some links to related issues for more background - #2438 and #2591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] FluentSlider two-way binding issue

4 participants