Skip to content

[MenuButton] Add an optional start icon #2707

Merged
vnbaaij merged 3 commits intomicrosoft:devfrom
adtaylor-cs:users/adtaylor-cs/menubutton-icon
Sep 25, 2024
Merged

[MenuButton] Add an optional start icon #2707
vnbaaij merged 3 commits intomicrosoft:devfrom
adtaylor-cs:users/adtaylor-cs/menubutton-icon

Conversation

@adtaylor-cs
Copy link
Copy Markdown
Contributor

Pull Request

📖 Description

This is a small PR to add the ability to add an icon to the start of a FluentMenuButton.

🎫 Issues

N/A

👩‍💻 Reviewer Notes

This is a pretty small change, and I've added an example to the Demo site. The result is as seen in this screenshot:

image

📑 Test Plan

Added to the existing FluentMenuButton unit test.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

N/A

@vnbaaij vnbaaij changed the title Add an optional start icon for the FluentMenuButton [MenuButton] Add an optional start icon Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants