[Button] Add StopPropagation + UnitTests#2732
Merged
Conversation
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Collaborator
|
Wr could add a tag |
dvoituron
approved these changes
Sep 28, 2024
Collaborator
Author
We have the vNext label. I added it to this PR, just as we do with the issues. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
Collaborator
Author
|
V5 PR created as well (#2733) |
|
Have nothing to add, just want to say thank you for this addition. Have had problems with event propagation :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
StopPropagationparameter toFluentButtontop prevent click for bubbling up to parent elements.2 tests added to confirm it works as expected