[General] Apply global color-scheme to reflect theme in use#2854
Merged
vnbaaij merged 1 commit intomicrosoft:devfrom Oct 24, 2024
Merged
[General] Apply global color-scheme to reflect theme in use#2854vnbaaij merged 1 commit intomicrosoft:devfrom
vnbaaij merged 1 commit intomicrosoft:devfrom
Conversation
Collaborator
|
You can use a style like this to do the same thing... but maybe it's easier to add a |
dvoituron
approved these changes
Oct 24, 2024
Contributor
Author
The media query strategy only works if system theme is in use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This pull request includes changes to improve theme management in the
FluentDesignThemecomponent and updates to the CSS to support these changes.A new data attribute (
data-theme) is added to body and updated every time theme changes.In
reboot.cssthis attribute is used to control the value ofcolor-scheme: this ensure all browser-managed components (like scrollbars) matches theme in use.Before:
After:
✅ Checklist
General