Skip to content

[InputFile] Make it work icw a loading Button#2940

Merged
vnbaaij merged 2 commits intomicrosoft:devfrom
MarvinKlein1508:anchor-fluentinput-issue
Nov 18, 2024
Merged

[InputFile] Make it work icw a loading Button#2940
vnbaaij merged 2 commits intomicrosoft:devfrom
MarvinKlein1508:anchor-fluentinput-issue

Conversation

@MarvinKlein1508
Copy link
Copy Markdown
Collaborator

Pull Request

📖 Description

When a FluentButton is being used as an anchor to trigger a FluentInputFile in combination with the property Loading then the registered event will be lost once the button renders again to display the loading style. This PR fixes this by reattaching the event when it's necessary.

🎫 Issues

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

Perhaps you might want to add a test-case for this. I sadly don't know how to do this but I will take a look on it when you add one to learn from it! 😀

@vnbaaij vnbaaij dismissed dvoituron’s stale review November 17, 2024 20:52

seems like a glitch. No need to hold merging back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants