[InputFile] Make it work icw a loading Button#2940
Merged
vnbaaij merged 2 commits intomicrosoft:devfrom Nov 18, 2024
MarvinKlein1508:anchor-fluentinput-issue
Merged
[InputFile] Make it work icw a loading Button#2940vnbaaij merged 2 commits intomicrosoft:devfrom MarvinKlein1508:anchor-fluentinput-issue
vnbaaij merged 2 commits intomicrosoft:devfrom
MarvinKlein1508:anchor-fluentinput-issue
Conversation
vnbaaij
approved these changes
Nov 16, 2024
dvoituron
previously requested changes
Nov 16, 2024
seems like a glitch. No need to hold merging back
vnbaaij
requested changes
Nov 17, 2024
vnbaaij
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
When a
FluentButtonis being used as an anchor to trigger aFluentInputFilein combination with the propertyLoadingthen the registered event will be lost once the button renders again to display the loading style. This PR fixes this by reattaching the event when it's necessary.🎫 Issues
✅ Checklist
General
Component-specific
⏭ Next Steps
Perhaps you might want to add a test-case for this. I sadly don't know how to do this but I will take a look on it when you add one to learn from it! 😀