You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's certainly a good idea that we haven't worked on yet (although we don't know why 😉).
To generalize this change, could you also add these types?
This would make it possible to have text types that don't currently exist in our Lib, while staying with the FluentUI style.
It's certainly a good idea that we haven't worked on yet (although we don't know why 😉).
To generalize this change, could you also add these types? This would make it possible to have text types that don't currently exist in our Lib, while staying with the FluentUI style.
Color
Number
Search
Password
@dvoituron I added the Color in the PR, for Number you already have the number input. The Password value is already there and Search does not do anything else (in my browser).
What about the date related fields? Month, Date, DateTimeLocal, Week?
For Number you already have the number input. The Password value is already there and Search does not do anything else (in my browser).
What about the date related fields? Month, Date, DateTimeLocal, Week?
Some people have a problem with FluentNumberField encompassing the fluent-number-field element. This could be an alternative for them.
The same applies to the password, which would use the ‘default’ HTML input element.
Search will be detected by the accessibility features of browsers as a ‘search’ element: Enter sends the value to the server and a cross is displayed in Edge and Chrome when the component is active.
Date components already exist in FluentUI Lib and we never received issues about that :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2970
Pull Request
📖 Description
Add support for html color picker
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps