[InputFile] [Docs] Add null check on initialization#3062
Merged
vnbaaij merged 2 commits intomicrosoft:devfrom Dec 18, 2024
MarvinKlein1508:fix-3061
Merged
[InputFile] [Docs] Add null check on initialization#3062vnbaaij merged 2 commits intomicrosoft:devfrom MarvinKlein1508:fix-3061
vnbaaij merged 2 commits intomicrosoft:devfrom
MarvinKlein1508:fix-3061
Conversation
vnbaaij
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR adds a null check to
FluentInputFile.razor.jsto prevent a crash which happens when the user leaves the page before theFluentInputFilehas been fully initialized. Without this null check the app might eventually crash.In addition this PR also adds a
try/catchfor theCodeSnippetcomponent for the demo sites. Which has the same problem on fast navigations. Here a null check is not possible becausehljsis not null and the javascript which is being executed is a third party library.🎫 Issues
Fixes #3061
📑 Test Plan
✅ Checklist
General
Component-specific