Merged
Conversation
Collaborator
|
Can you include a picture of what the issue is? I can't deduce from the repro link what the problem is. |
Contributor
Author
|
In this video i show the problem: recording.mp4With the fix in this PR: recording.2.mp4 |
vnbaaij
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Fix DataGrid not resizing right when there is aside and ResizeType = null
The newer version does not account the sidebar when resizing!
repro: https://f4n0.github.io/BlazorGenerator/list
Code: https://github.com/f4n0/BlazorGenerator/blob/master/src/BlazorGenerator/Components/DataGrid/ListDataGrid.razor#L23
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps