[Lists] Trigger field changed when in multiple mode#3294
Merged
vnbaaij merged 3 commits intomicrosoft:devfrom Feb 5, 2025
Merged
[Lists] Trigger field changed when in multiple mode#3294vnbaaij merged 3 commits intomicrosoft:devfrom
vnbaaij merged 3 commits intomicrosoft:devfrom
Conversation
dvoituron
reviewed
Feb 3, 2025
dvoituron
reviewed
Feb 3, 2025
joriverm
force-pushed
the
fixes/AutoCompleteContext
branch
from
2640484 to
f20017f
Compare
joriverm
force-pushed
the
fixes/AutoCompleteContext
branch
from
f20017f to
3107fd6
Compare
dvoituron
approved these changes
Feb 5, 2025
vnbaaij
approved these changes
Feb 5, 2025
vnbaaij
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
autocomplete doesnt trigger the fieldchanged as the default ChangeHandler, which handles the validation/fieldchanged event of the editform, this was fixed by always triggering the event on selection changes for both single and multiple mode.
i also noticed that the list base didnt implement the binding expression property, so the fieldidentifier was always wrong.
🎫 Issues
Fix #3115
👩💻 Reviewer Notes
this was tested using the form page from the demo project. i am currently going through the tests to check out if i missed anything
📑 Test Plan
none, i dont see how to put this in a test without adding a binding the bunit test and rendering a validator at the same time. not sure if its worth it?
✅ Checklist
General
Component-specific
⏭ Next Steps
N/A