[Demo] Fix (most) printing issues when trying to print the page#3370
Merged
vnbaaij merged 2 commits intomicrosoft:devfrom Feb 15, 2025
Merged
Conversation
dvoituron
approved these changes
Feb 15, 2025
vnbaaij
approved these changes
Feb 15, 2025
Collaborator
|
This is great. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Solving several issues like stated in the issue #3345:
🎫 Issues
#3345
👩💻 Reviewer Notes
If you find any more issues on pages please let me know, it was really hard to go about each page and find elements that are not correctly printed yet, so i might have missed some!
📑 Test Plan
Run the Demo website locally and try to print the pages in multiple browsers. I have tried Chrome and Microsoft Edge.
✅ Checklist
General
I have added tests for my changes.(Not applicable i think?)I have updated the project documentation to reflect my changes.(Not applicable i think?)