[DataGrid] Add IGridSort interface, fixes sorting when using ItemsProvider#3460
[DataGrid] Add IGridSort interface, fixes sorting when using ItemsProvider#3460vnbaaij merged 10 commits intomicrosoft:devfrom
Conversation
…ed a new 'StaticGridSort' class.
vnbaaij
left a comment
There was a problem hiding this comment.
Apart from the namespace name and whitespace remarks, think this looks quite good already. 👍
I don't understand the StaticGridSort purpose. Is it the default IGridSort that gets applied. I don't see it called anywhere (yet?). If it is indeed the default, than I'd suggest to name it like that as well DefaultGridSort
|
@vnbaaij - Thanks for the feedback! It was late last night when I created this and so I was struggling to come up with a good name for the new class. I'm still not certain that |
|
Very nice way of solving the issue |
Fixes #3290
Before writing unit tests etc... I wanted to get feedback on whether this would be an acceptable approach.
Pull Request
📖 Description
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps