[MainLayout] Remove double header reduction#3841
Merged
dvoituron merged 3 commits intomicrosoft:devfrom Jun 3, 2025
Tyme-Bleyaert:bug/3836/fix-double-header-height-subtraction-mainlayout
Merged
[MainLayout] Remove double header reduction#3841dvoituron merged 3 commits intomicrosoft:devfrom Tyme-Bleyaert:bug/3836/fix-double-header-height-subtraction-mainlayout
dvoituron merged 3 commits intomicrosoft:devfrom
Tyme-Bleyaert:bug/3836/fix-double-header-height-subtraction-mainlayout
Conversation
vnbaaij
approved these changes
May 28, 2025
Collaborator
|
@Tyme-Bleyaert for PR naming, please use the syntax For the component name, leave out the Fluent part. For the description, do not use the issue number in there. Just a clear, short summary. In the PR description, use the 'fix #issuenumber' syntax to automatically link the issue to the PR. That way the issue gets closed when the pr is merged. |
Collaborator
|
@vnbaaij perhaps it's a good idea to add these details to the contributing.md |
Collaborator
|
Yeah, was thinking that too. Will do that next week. |
auto-merge was automatically disabled
June 2, 2025 14:48
Head branch was pushed to by a user without write access
dvoituron
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3836
Pull Request
📖 Description
Removed header height reductions from
Mainlayout, added a vertical stack.Stacks now always have 100% height.
I've kept the
--header-heightvariable as it might be used by some users already.🎫 Issues
#3836
👩💻 Reviewer Notes
I think we should take cases in consideration when the navigation or main content exceeds the 100%.
We can either re-add the subtraction to the vertical stack and add a parameter to the component
SubHeaderHeightand subtract this from the horizontal stack.Or we can let the user define the styles for these stacks themselves.
📑 Test Plan
Added test to check default styles of mainlayout stacks
✅ Checklist
General
Component-specific