[Drag&Drop] Add stopPropagation to DropZone#4045
Merged
vnbaaij merged 5 commits intomicrosoft:devfrom Jul 31, 2025
Merged
Conversation
Collaborator
|
Why not add a parameter like we did in FluentButton? That way, the developer can decide when to use it. /// <summary>
/// Gets or sets a way to prevent further propagation of the current event in the capturing and bubbling phases.
/// </summary>
[Parameter]
public bool StopPropagation { get; set; } = false; |
Collaborator
Author
Good call! I will adjust the PR early tomorrow. |
Collaborator
Author
|
Done. I've also added a test for the new parameter. |
dvoituron
approved these changes
Jul 30, 2025
vnbaaij
approved these changes
Jul 31, 2025
This was referenced Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Merged
This was referenced Dec 1, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR adds stopPropagation to the
FluentDropZonecomponent. This allows the component to be used in nestedFluentDragContainercomponents.🎫 Issues
This PR fixes #3925
👩💻 Reviewer Notes
@dvoituron I'm not sure if I can always set
stopPropagation. I've seen that you do this for preventDeafult based onDroppable. But I couldn't find any downside in adding this attribute.📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps
I've got a working demo with three nested
FluentDragContainers which I prepare for PR as well. Still optimizing styling. Here is a sneak peak:https://github.com/user-attachments/assets/5c5eefe0-1eb7-4e37-93f0-7ce5f9775cb6