[DatePicker & TimePicker] Fix FocusAsync throwing null exception#4167
Merged
vnbaaij merged 2 commits intomicrosoft:devfrom Sep 26, 2025
Merged
[DatePicker & TimePicker] Fix FocusAsync throwing null exception#4167vnbaaij merged 2 commits intomicrosoft:devfrom
vnbaaij merged 2 commits intomicrosoft:devfrom
Conversation
vnbaaij
approved these changes
Sep 26, 2025
8 tasks
This was referenced Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Merged
This was referenced Dec 1, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR fixes an issue with the
FocusAsyncmethod within theFluentDatePickerandFluentTimePickercomponents.Both components inherit from
FluentInputBase<T>but don't assign any reference to the actualElementproperty. This PR mainly does two things to fix this.FocusAsyncmethod from theFluentInputBaseoverwritable by addingvirtualto the method signature@reffor both componentsSince the
FluentDatePickeruses theFluentTextFieldcomponent internally it overwrites theFocusAsyncmethod and passes it down to the actual component.🎫 Issues
Fixes: #4166
👩💻 Reviewer Notes
The missing behaviour can be reproduced with this code in the IssueTester
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps