[SortableList] Handle JS errors in a better way#4286
Merged
Conversation
dvoituron
requested changes
Nov 3, 2025
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
dvoituron
approved these changes
Nov 3, 2025
This was referenced Nov 28, 2025
Merged
Merged
This was referenced Dec 7, 2025
Merged
This was referenced Dec 22, 2025
Merged
Bump Microsoft.FluentUI.AspNetCore.Components from 4.13.1 to 4.13.2
MWG-Logan/CW-ProjectReporting#37
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4285 by implementing
IAsynDisposableand checking disposed state inOnAfterRenderAsync.The error mentioned in the issue happened when moving from the SortableList page to anther page. In effect the JS function was being called when the element was already disposed of. This is now checked in a better way.