Skip to content

[Dialog] Fix error when module hasn't finished loading#4324

Merged
vnbaaij merged 2 commits intomicrosoft:devfrom
JamesNK:jamesnk/dialog-load-module1
Nov 17, 2025
Merged

[Dialog] Fix error when module hasn't finished loading#4324
vnbaaij merged 2 commits intomicrosoft:devfrom
JamesNK:jamesnk/dialog-load-module1

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Nov 17, 2025

Fixes #4311

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 17, 2025

The problem with the TCS approach is displaying a dialog in OnInitialize + await will block OnAfterRenderAsync from being called and will deadlock.

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 17, 2025

Changed to not track previously selected element if module hasn't been loaded.

@vnbaaij vnbaaij merged commit 27e759e into microsoft:dev Nov 17, 2025
2 checks passed
@vnbaaij vnbaaij changed the title Fix dialog provider error when module hasn't finished loading [Dialog] Fix error when module hasn't finished loading Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Error in FluentDialogProvider when displaying dialog on page load

4 participants