Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an accessibility issue by changing the tabindex attribute in FluentProfileMenu from "1" to "0", allowing the component to follow the natural tab order instead of forcing a custom order.
- Changed hardcoded
tabindex="1"totabindex="0"in the FluentProfileMenu component - Updated all snapshot test files to reflect the new tabindex value
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/Components/ProfileMenu/FluentProfileMenu.razor | Updated the tabindex attribute from "1" to "0" in the root div element |
| tests/Core/ProfileMenu/FluentProfileMenuTests.FluentProfileMenu_Default.verified.razor.html | Updated snapshot test to verify tabindex="0" |
| tests/Core/ProfileMenu/FluentProfileMenuTests.FluentProfileMenu_Customized.verified.razor.html | Updated snapshot test to verify tabindex="0" |
| tests/Core/ProfileMenu/FluentProfileMenuTests.FluentProfileMenu_StartEndTemplate.verified.razor.html | Updated snapshot test to verify tabindex="0" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.3%
|
dvoituron
approved these changes
Dec 9, 2025
This was referenced Feb 13, 2026
Closed
Merged
This was referenced Feb 23, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4397. The
FluentProfileMenuused a hard-codedtabindexattribute value of1(see #4104), This PR sets it to use0PS - I did a search on the rest of the codebase. We do not use a value of
1anywhere else.