Remove unused deps #1576
Merged
Remove unused deps #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Removing some devDeps that don't seem to be used by the Drawer component. The deps are pulling in a version of string_decoder that is discouraged from being used.
Verification
Re-ran "gradle init" to make sure that it's not adding back the devDependencies
Built and booted Android FURN test app. Unfortunately Drawer was also broken without my changes, but given that the change builds and these are dev dependencies, it shouldn't affect the FURN test app.
Pull request checklist
This PR has considered (when applicable):