useViewCommandFocus: Check that Focus exists in ViewManager first #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
JK, this breaks on iOS where I was hoping it would fix it. Hold... |
harrieshin
reviewed
Jul 22, 2022
harrieshin
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
See: #1535 (review)
This change should prevent some crashes we see on Platforms where RCTView doesn't have a
focuscommand exposed. This also happens to fix the Redbox we kept seeing on iOS :)Verification
E2E tests in CI should be good.
iOS no longer Redboxes on button clicks
Screen.Recording.2022-07-22.at.3.13.22.PM.mov
Pull request checklist
This PR has considered (when applicable):