Don't put Flatlists inside Scrollviews in FluentTester #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
harrieshin
approved these changes
Jul 22, 2022
rurikoaraki
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Another followup from #1535
Fix a longstanding yellow box error we had where we rendered a Flatlist inside a ScrollView. Flatlist doesn't like that. The two test pages have few enough items that we shouldn't see terrible performance.
Verification
No longer see the yellow box on TokenTest and ThemeTest
Scrolling on my M1 Mac mini seems fine.
Screen.Recording.2022-07-22.at.4.01.44.PM.mov
Pull request checklist
This PR has considered (when applicable):